Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't downgrade based on pinning #187

Closed
ghost opened this issue Feb 3, 2023 · 0 comments · Fixed by #256
Closed

can't downgrade based on pinning #187

ghost opened this issue Feb 3, 2023 · 0 comments · Fixed by #256
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Feb 3, 2023

I have Klotho v0.6.1:

$ klotho --version
Version: v0.6.1-darwin-amd64

I pin it to v0.6.0, and it tells me I'm already up to date:

$ klotho --set-option update.stream=open:v0.6.0 --update
already up to date on stream "open:v0.6.0".

$ klotho --version
Version: v0.6.1-darwin-amd64

Workaround:

# switch from open to pro
$ klotho --set-option update.stream=pro:latest --update
updated to the latest version on stream "pro:latest"

# switch from pro to open, with a pinned version
$ klotho --set-option update.stream=open:v0.6.0 --update
updated to the latest version on stream "open:v0.6.0"

$ klotho --version
Version: v0.6.0-darwin-amd64

# version is pinned correctly
$ klotho --update
already up to date on stream "open:v0.6.0".
@ghost ghost added the bug Something isn't working label Feb 3, 2023
@atorres-klo atorres-klo assigned jhsinger-klotho and ghost and unassigned jhsinger-klotho Feb 13, 2023
ghost pushed a commit that referenced this issue Feb 17, 2023
fix pin-and-downgrade
f794663 
Previously, if you tried to pin to a lower version, we would treat it as
a no-op (and keep you at your current version). Now, we'll perform the
update ("downdate").

This resolves #187.

We've had a few back-and-forths in this code, most recently #137. I
added unit tests to try and put this to bed for good, or at least
prevent further regressions.
ghost pushed a commit that referenced this issue Feb 17, 2023
fix pin-and-downgrade
79c314a 
Previously, if you tried to pin to a lower version, we would treat it as
a no-op (and keep you at your current version). Now, we'll perform the
update ("downdate").

This resolves #187.

We've had a few back-and-forths in this code, most recently #137. I
added unit tests to try and put this to bed for good, or at least
prevent further regressions.
@ghost ghost mentioned this issue Feb 17, 2023
Merged
@ghost ghost closed this as completed in #256 Feb 21, 2023
ghost pushed a commit that referenced this issue Feb 21, 2023
fix pin-and-downgrade
82fbdfa 
Previously, if you tried to pin to a lower version, we would treat it as
a no-op (and keep you at your current version). Now, we'll perform the
update ("downdate").

This resolves #187.

We've had a few back-and-forths in this code, most recently #137. I
added unit tests to try and put this to bed for good, or at least
prevent further regressions.

I found myself getting kinda confused about the various situations, so I
wrote a novel to explain it to myself. I figured I'd keep it around for
the next person.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix pin-and-downgrade klothoplatform/klotho
1 participant
@jhsinger-klotho