Update klotho checks #137
Merged
Update klotho checks #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This check was there intentionally. Let's say both the latest in both oss and pro is 0.6.0, and I'm on the oss stream. If I do It's very possible I got some other aspect of the workflow wrong, but I think we do need to preserve that behavior at least. |
|
Per convo w/ yuval, added the check for the stream type If the user pins a version and that version is not If the user pins a version and it's not latest and it does not match the version they are on, or they pin it to |
ghost
reviewed
Jan 25, 2023
pkg/cli/cli_options.go
Outdated
| @@ -126,3 +128,19 @@ func OptionOrDefault(given string, defaultValue string) string { | |||
| } | |||
| return given | |||
| } | |||
|
|
|||
| func ShouldCheckForUpdate(given string, defaultValue string, currVersion string) bool { | |||
There was a problem hiding this comment.
small: can we rename these args? something like
Suggested change
| func ShouldCheckForUpdate(given string, defaultValue string, currVersion string) bool { | |
| func ShouldCheckForUpdate(updateStreamOverride string, defaultUpdateStream string, currVersion string) bool { |
and then similarly below:
givenParts=>streamOverridePartsgivenVersion=>streamOverrideVersion
There was a problem hiding this comment.
yep can change for sure
ghost
approved these changes
Jan 25, 2023
ghost
approved these changes
Jan 25, 2023
|
ghost
pushed a commit
that referenced
this pull request
Feb 17, 2023
Previously, if you tried to pin to a lower version, we would treat it as
a no-op (and keep you at your current version). Now, we'll perform the
update ("downdate").
This resolves #187.
We've had a few back-and-forths in this code, most recently #137. I
added unit tests to try and put this to bed for good, or at least
prevent further regressions.
ghost
pushed a commit
that referenced
this pull request
Feb 17, 2023
Previously, if you tried to pin to a lower version, we would treat it as
a no-op (and keep you at your current version). Now, we'll perform the
update ("downdate").
This resolves #187.
We've had a few back-and-forths in this code, most recently #137. I
added unit tests to try and put this to bed for good, or at least
prevent further regressions.
ghost
mentioned this pull request
Merged
ghost
pushed a commit
that referenced
this pull request
Feb 21, 2023
Previously, if you tried to pin to a lower version, we would treat it as
a no-op (and keep you at your current version). Now, we'll perform the
update ("downdate").
This resolves #187.
We've had a few back-and-forths in this code, most recently #137. I
added unit tests to try and put this to bed for good, or at least
prevent further regressions.
I found myself getting kinda confused about the various situations, so I
wrote a novel to explain it to myself. I figured I'd keep it around for
the next person.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the second stream check will result in false update messages being printed.
Here's an example where I set my options to
oss:v0.5.19If the user pins the version to the current version, it's just never going to match the stream check because the current stream is always the default value
oss:latestI'm pretty sure the first check for the semver is good enough since that takes the latest and converts it to the version number and compares that to the running builds version in the build file.
Discussion: Not sure if the initial intention was to notify the user every time they run, that their pinned version is behind latest, but if that's the case, then this needs to be merged in https://github.com/klothoplatform/klotho-server/pull/27. The server was checking w/ the stream version provided instead of actual latest.