Skip to content
This repository has been archived by the owner on Oct 29, 2022. It is now read-only.

Add pre-commit #52

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Add pre-commit #52

merged 2 commits into from
Sep 1, 2022

Conversation

jonafato
Copy link
Collaborator

@jonafato jonafato commented Sep 1, 2022

Changes:

  • Add an initial pre-commit config file
  • Run pre-commit run --all-files to get initial formatting consistent with style and prevent future unrelated changes from creeping in

Notes:

  • Probably needs a line in contributing documentation to let contributors know they can install pre-commit to take care of autoformatting
  • I plan to follow this up with some additional GitHub Actions work to automate the automations

Resolves #47

@kjaymiller
Copy link
Owner

I'm down with it. I've used pre-commit before but wasn't sure if it was something we'd want. I'm not entirely sure it's the most friendly for new devs

@jonafato
Copy link
Collaborator Author

jonafato commented Sep 1, 2022

I'm not entirely sure it's the most friendly for new devs

I think there are definitely cases where this is true, but the followup to run this in GitHub Actions will help a lot on that front.

@jonafato jonafato merged commit 6780e88 into main Sep 1, 2022
@jonafato jonafato deleted the pre-commit branch September 1, 2022 03:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DISCUSS] Black and iSort as pre-commit steps
2 participants