Skip to content
This repository has been archived by the owner on Oct 29, 2022. It is now read-only.

Run pre-commit in GitHub Actions #61

Open
jonafato opened this issue Sep 1, 2022 · 3 comments
Open

Run pre-commit in GitHub Actions #61

jonafato opened this issue Sep 1, 2022 · 3 comments
Assignees

Comments

@jonafato
Copy link
Collaborator

jonafato commented Sep 1, 2022

As a followup to #52, we should run these tasks in GitHub Actions. Generally speaking,

  • Autoformatters should commit changes back to pull requests
  • Linters, etc. should fail with an error like any other test step
@jonafato jonafato self-assigned this Sep 1, 2022
@kjaymiller
Copy link
Owner

Not sure this is possible (or at least will be supported long term) - https://github.com/pre-commit/action has been deprecated in favor of running their own CI

@jonafato
Copy link
Collaborator Author

jonafato commented Sep 2, 2022

It's possible, I've done it on tons of repositories. We don't need the official action for it. Self-assigned, so I'll follow up with a PR.

@jonafato
Copy link
Collaborator Author

jonafato commented Sep 3, 2022

This is half-addressed by #77. Autoformatters committing back to be addressed in another change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants