Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT/adding types for the role attribute instead of string #237

Merged
merged 3 commits into from
Jun 19, 2024
Merged

FEAT/adding types for the role attribute instead of string #237

merged 3 commits into from
Jun 19, 2024

Conversation

AugustinSorel
Copy link

Adding types for the role attribute instead of raw string. The types are taken from the w3 specs.

Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 09ff732

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kitajs/html Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@arthurfiorette
Copy link
Member

please add a changeset

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (e575ef8) to head (087ae2c).
Report is 4 commits behind head on master.

Current head 087ae2c differs from pull request most recent head 09ff732

Please upload reports for the commit 09ff732 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files           5        5           
  Lines         456      456           
=======================================
  Hits          454      454           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AugustinSorel
Copy link
Author

please add a changeset

Done 👍

Signed-off-by: Arthur Fiorette <[email protected]>
@arthurfiorette arthurfiorette enabled auto-merge (squash) June 19, 2024 11:50
@arthurfiorette arthurfiorette merged commit b42e517 into kitajs:master Jun 19, 2024
5 checks passed
@arthurfiorette arthurfiorette mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants