Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inputmode to HtmlTag #202

Merged
merged 4 commits into from
May 6, 2024
Merged

Add inputmode to HtmlTag #202

merged 4 commits into from
May 6, 2024

Conversation

Jeaciaz
Copy link

@Jeaciaz Jeaciaz commented May 4, 2024

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode is missing from the types, though transpiling fine. This is a small type patch.

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/inputmode is missing from the types, though transpiling fine. This is a small type patch.

Signed-off-by: Sergei Kniazev <[email protected]>
Copy link

changeset-bot bot commented May 4, 2024

🦋 Changeset detected

Latest commit: 5820112

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@kitajs/html Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@arthurfiorette
Copy link
Member

Can you add (string & {}) as an option too? This way auto complete still works while also allowing any string to work.

Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (af06ac8) to head (f4957ff).
Report is 4 commits behind head on master.

❗ Current head f4957ff differs from pull request most recent head 05bf560. Consider uploading reports for the commit 05bf560 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #202   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          457       457           
=========================================
  Hits           457       457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/html/jsx.d.ts Outdated Show resolved Hide resolved
Signed-off-by: Arthur Fiorette <[email protected]>
@arthurfiorette arthurfiorette merged commit aa57511 into kitajs:master May 6, 2024
2 of 5 checks passed
@arthurfiorette
Copy link
Member

thanks!

@arthurfiorette arthurfiorette mentioned this pull request May 6, 2024
@Jeaciaz Jeaciaz deleted the patch-1 branch May 7, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants