Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Picture tag and srcset to Source tag #176

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

ArkahnX
Copy link

@ArkahnX ArkahnX commented Apr 3, 2024

This adds the Picture element, as well as the srcset attribute to the Source element (used when you have the Source element within a Picture element)

Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: 10ec3a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@kitajs/html Major
@kitajs/fastify-html-plugin Major
@kitajs/ts-html-plugin Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@arthurfiorette
Copy link
Member

Thanks! Can you add a changesets for it?

@ArkahnX
Copy link
Author

ArkahnX commented Apr 3, 2024

Sorry about that, I've included it as a minor changeset, which I believe should be appropriate, but I can downgrade it if needed

@arthurfiorette arthurfiorette enabled auto-merge (squash) April 3, 2024 12:59
@arthurfiorette
Copy link
Member

Thanks!

@arthurfiorette arthurfiorette self-assigned this Apr 3, 2024
@arthurfiorette arthurfiorette added enhancement New feature or request html-runtime Related to @kitajs/html labels Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc012f0) to head (10ec3a1).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          465       465           
=========================================
  Hits           465       465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arthurfiorette arthurfiorette merged commit 4ffe38c into kitajs:master Apr 3, 2024
8 checks passed
@arthurfiorette arthurfiorette mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request html-runtime Related to @kitajs/html
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants