Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add jsx-dev-runtime #166

Merged
merged 4 commits into from
Mar 27, 2024
Merged

feat: add jsx-dev-runtime #166

merged 4 commits into from
Mar 27, 2024

Conversation

aralroca
Copy link

Related to #159

Copy link

changeset-bot bot commented Mar 27, 2024

🦋 Changeset detected

Latest commit: c55f730

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@kitajs/html Patch
@kitajs/fastify-html-plugin Patch
@kitajs/ts-html-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Arthur Fiorette <[email protected]>
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d56c683) to head (c55f730).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          465       465           
=========================================
  Hits           465       465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


### Minor Changes

- [`bab34f8`](https://github.com/kitajs/html/pull/166/commits/bab34f87a9043b117b528ca3789dcba47fb8ca73)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our changeset is generated automatically. You just need to run pnpm changeset at the project root... Can you reset this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, good to know! Thanks

@arthurfiorette
Copy link
Member

Hey, could you also document about the possibility of using https://github.com/aralroca/prerender-macro with kitajs/html?


Also, did you ran any performance tests to see how much this is helping with kita's performance?

@aralroca
Copy link
Author

@arthurfiorette can you give me a hand with the performance test and tell me where are the current performance tests? by the way, do you prefer it in another PR or in this one? thanks

@arthurfiorette
Copy link
Member

@arthurfiorette can you give me a hand with the performance test and tell me where are the current performance tests? by the way, do you prefer it in another PR or in this one? thanks

no need to do that, it was just out of curiosity... Our benchmark setup only runs on nodejs for now XD

@arthurfiorette arthurfiorette merged commit d4e1d36 into kitajs:master Mar 27, 2024
8 checks passed
This was referenced Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants