[ci ckip] Merge from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killerprojecte
pushed a commit
that referenced
this pull request
Jul 11, 2023
The end gateway is supposed to teleport the person who threw the ender pearl. The changes more closely mirror Vanilla behavior. The current exceptions to Vanilla behavior are: 1. The first teleportation attempt for the end gateway always fails 2. If the ender pearl thrower is riding a vehicle, the thrower is dismounted from their vehicle. I don't see any solutions for #1 right now. The root issue is that since the end gateway does not have a target location, it has to search for one. However, it can _fail_ to find a target location, in which case the teleportation should not occur. Since the search must take place asynchronously, it requires the entity to be removed from the world. For #2, this is because Vanilla's behavior is broken and does not correctly teleport players riding boats. We can fix this by simply dismounting the player and teleporting them separately of their boat, which seems to be what Vanilla is trying to do given it does _not_ try to teleport the root vehicle of the player. This is a partial fix to PaperMC#51
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.