Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End Gate portal doesn't work. (The portal that you throw an enderpearl into and it brings you to the end city islands.) #51

Open
SlayorPlayz opened this issue Apr 18, 2023 · 4 comments
Labels
type: bug Something doesn't work as it was intended to. version: 1.19.4 Game version 1.19.4

Comments

@SlayorPlayz
Copy link

Expected behavior

Ender pearl goes through and teleports you to the islands.

Observed/Actual behavior

Ender pearls do not work at all when thrown through the portal.

Steps/models to reproduce

Throw an enderpearl through the end gate.

Plugin and Datapack List

N/A

Folia version

[15:39:03 INFO]: This server is running Folia version git-Folia-"41c5548" (MC: 1.19.4) (Implementing API version 1.19.4-R0.1-SNAPSHOT) (Git: 41c5548)
You are 2 version(s) behind

1 version was just debug. And the other was: dddaab9

Other

I teleported through the portal by breaking the bedrock around it and it had a landable area for the enderpearls.

@SlayorPlayz SlayorPlayz added status: needs triage type: bug Something doesn't work as it was intended to. labels Apr 18, 2023
@sofianedjerbi
Copy link
Contributor

Can reproduce. The interaction between the portal and an enderpearl don't work; but the portal itself works fine.

@sofianedjerbi
Copy link
Contributor

It seems that the enderpearl go through the portal but since the area isn't loaded, it doesn't trigger any teleportation

@MineSunshineone
Copy link

MineSunshineone commented Jun 13, 2023

fixed in 23b6f9e incorrect

Spottedleaf added a commit that referenced this issue Jul 10, 2023
The end gateway is supposed to teleport the person who threw
the ender pearl.

The changes more closely mirror Vanilla behavior. The current
exceptions to Vanilla behavior are:

1. The first teleportation attempt for the end gateway always fails
2. If the ender pearl thrower is riding a vehicle, the thrower is
   dismounted from their vehicle.

I don't see any solutions for #1 right now. The root issue is that
since the end gateway does not have a target location, it has to
search for one. However, it can _fail_ to find a target location,
in which case the teleportation should not occur. Since the search
must take place asynchronously, it requires the entity to be
removed from the world.

For #2, this is because Vanilla's behavior is broken and does not
correctly teleport players riding boats. We can fix this by simply
dismounting the player and teleporting them separately of their boat,
which seems to be what Vanilla is trying to do given it does _not_
try to teleport the root vehicle of the player.

This is a partial fix to #51
@Spottedleaf
Copy link
Member

Partially fixed by b5fc6d0

@kashike kashike added version: 1.19.4 Game version 1.19.4 and removed version: 1.19 labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something doesn't work as it was intended to. version: 1.19.4 Game version 1.19.4
Projects
None yet
Development

No branches or pull requests

5 participants