Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.67.x-blue] [RHPAM-4876] exclusion on kie server affect custom endpoints #3016

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

github-actions[bot]
Copy link

Backport: #3011

Note: CI is not automatically triggered on backported PRs, please comment 'ok to test' to launch Jenkins jobs

  • Add resteasy-jackson2-provider in kie-server.war

JIRA:
https://issues.redhat.com/browse/RHPAM-4876

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

- Add resteasy-jackson2-provider in kie-server.war
@mareknovotny
Copy link
Member

ok to test

@mareknovotny
Copy link
Member

i just noticed additional commit to revert unwanted jaxb change, is that included in original PR #3011 ?

@mareknovotny
Copy link
Member

jenkins do fdb

@tkobayas
Copy link
Contributor

tkobayas commented Jan 24, 2024

@mareknovotny

i just noticed additional commit to revert unwanted jaxb change, is that included in original PR #3011 ?

The change is not included in the original PR #3011

The original 7.x branch had another commit that changed jaxb from sun to glassfish for JDK17 compatibility (which is not required for 7.67.x).

f25e859#diff-e4e743bb7805907178a0f30766bb2c000c504e795cfcb11c231c8aa28a132d7a

Then, somehow the backport action added the wrong jaxb change for these backport PRs (probably because the line is next to the original PR diff).

cc892b1#diff-e4e743bb7805907178a0f30766bb2c000c504e795cfcb11c231c8aa28a132d7a

So I removed the unwanted changes manually.

@tkobayas
Copy link
Contributor

Jenkins PR: Not related to this PR. Flaky

[2024-01-23T10:19:48.205Z] [ERROR] Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 12.823 s <<< FAILURE! - in org.kie.server.client.LoadBalancerClientTest
[2024-01-23T10:19:48.205Z] [ERROR] testDefaultLoadBalancerNoServersAvailable(org.kie.server.client.LoadBalancerClientTest)  Time elapsed: 5.466 s  <<< ERROR!
[2024-01-23T10:19:48.205Z] org.kie.server.common.rest.NoEndpointFoundException: No available endpoints found

@mareknovotny
Copy link
Member

jenkins retest this please

Copy link

sonarcloud bot commented Jan 24, 2024

@mareknovotny mareknovotny removed the request for review from Ginxo January 24, 2024 13:04
@mareknovotny mareknovotny merged commit 98cad78 into 7.67.x-blue Jan 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants