Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHPAM-4876] exclusion on kie server affect custom endpoints #3011

Merged

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Jan 17, 2024

  • Add resteasy-jackson2-provider in kie-server.war

JIRA:
https://issues.redhat.com/browse/RHPAM-4876

for 7.67.x -> #3015
for 7.67.x-blue -> #3016

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@tkobayas tkobayas force-pushed the RHPAM-4876-revert-exclusion-7.x branch from 4707b4f to c0d3b0a Compare January 17, 2024 09:28
- Add resteasy-jackson2-provider in kie-server.war
@tkobayas tkobayas force-pushed the RHPAM-4876-revert-exclusion-7.x branch from c0d3b0a to 4e62f2d Compare January 18, 2024 03:08
@tkobayas tkobayas marked this pull request as ready for review January 19, 2024 08:51
@@ -91,9 +91,13 @@

<include>org.glassfish.jaxb:jaxb-runtime</include>
<include>org.glassfish.jaxb:jaxb-xjc</include>

<include>org.jboss.resteasy:resteasy-jackson2-provider</include>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding resteasy-jackson2-provider to be able to create a custom Rest endpoint with json conversion.

@mareknovotny mareknovotny added backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch labels Jan 22, 2024
@mareknovotny
Copy link
Member

jenkins do fdb

Copy link
Member

@mareknovotny mareknovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mareknovotny mareknovotny merged commit 967abf4 into kiegroup:main Jan 22, 2024
11 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
- Add resteasy-jackson2-provider in kie-server.war
github-actions bot pushed a commit that referenced this pull request Jan 22, 2024
- Add resteasy-jackson2-provider in kie-server.war
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

mareknovotny pushed a commit that referenced this pull request Jan 24, 2024
…#3015)

* [RHPAM-4876] exclusion on kie server affect custom endpoints (#3011)

- Add resteasy-jackson2-provider in kie-server.war

* - revert unwanted jaxb change

---------

Co-authored-by: Toshiya Kobayashi <[email protected]>
mareknovotny pushed a commit that referenced this pull request Jan 24, 2024
…oints (#3016)

* [RHPAM-4876] exclusion on kie server affect custom endpoints (#3011)

- Add resteasy-jackson2-provider in kie-server.war

* - revert unwanted jaxb change

---------

Co-authored-by: Toshiya Kobayashi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.67.x Generate backport PR for 7.67.x branch backport-7.67.x-blue Generate backport PR for 7.67.x-blue branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants