Skip to content
This repository was archived by the owner on Apr 11, 2023. It is now read-only.

[POC] Jaeger Integration#888

Closed
aljesusg wants to merge 1 commit intokiali:masterfrom
aljesusg:jaeger_poc
Closed

[POC] Jaeger Integration#888
aljesusg wants to merge 1 commit intokiali:masterfrom
aljesusg:jaeger_poc

Conversation

@aljesusg
Copy link
Contributor

@aljesusg aljesusg commented Dec 17, 2018

** NOT MERGE **
Required: kiali/kiali#748

Screenshots

screenshot from 2018-12-17 13-35-33
screenshot from 2018-12-17 13-35-22
screenshot from 2018-12-17 13-35-11
screenshot from 2018-12-17 13-34-56

@aljesusg aljesusg added the do not merge A PR is not ready to merge label Dec 17, 2018
@abonas
Copy link
Contributor

abonas commented Dec 18, 2018

@jotak fyi, some work is done on the tabs here as well.

@aljesusg aljesusg changed the title PoC Jaeger Integration [POC] Jaeger Integration Dec 18, 2018
@aljesusg
Copy link
Contributor Author

aljesusg commented Jan 23, 2019

@abonas jaeger 1.9 was merged in istio 1.1 today istio/istio#11149 so I'll update this PR Is tehre any feddback from @kiali/ux-reviewers about the toolbars?

@abonas
Copy link
Contributor

abonas commented Jan 24, 2019 •
edited
Loading

@abonas jaeger 1.9 was merged in istio 1.1 today istio/istio#11149 so I'll update this PR Is tehre any feddback from @kiali/ux-reviewers about the toolbars?

@aljesusg this is great news!!!
Which toolbars? of the jaeger page? Were particular questions raised to @kiali/ux-reviewers in an issue in the design repo or in a meeting? (I don't recall they were, but I might have missed something)
If not, please open an issue so this can be discussed ASAP with them.

@aljesusg
Copy link
Contributor Author

aljesusg commented Jan 25, 2019

Toolbar related with the jaeger interaction, in the service page traces tab and in distributed tracing link. I'm working in a new PR with all changes by steps, I think that I'll send the PR today but the style and the toolbar will be like this @abonas.

@aljesusg
Copy link
Contributor Author

aljesusg commented Jan 28, 2019

Close by #965

@aljesusg aljesusg closed this Jan 28, 2019
@aljesusg aljesusg deleted the jaeger_poc branch September 9, 2019 08:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

do not merge A PR is not ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aljesusg @abonas