Skip to content

Update Jaeger to 1.9#11149

Merged
wenchenglu merged 1 commit intoistio:release-1.1from
objectiser:jaeger1.9
Jan 23, 2019
Merged

Update Jaeger to 1.9#11149
wenchenglu merged 1 commit intoistio:release-1.1from
objectiser:jaeger1.9

Conversation

@objectiser
Copy link
Contributor

No description provided.

@objectiser
Copy link
Contributor Author

/retest

@douglas-reid
Copy link
Contributor

Should this be against master now, or is this needed for 1.1 ?

@objectiser
Copy link
Contributor Author

@aljesusg Is Jaeger 1.9 required for Kiali in 1.1? If not, then I will move the change to master.

@aljesusg
Copy link
Contributor

yes please @objectiser we have PR's waiting for this

Copy link
Member

@gyliu513 gyliu513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@objectiser
Copy link
Contributor Author

@douglas-reid I have opened #11185 against master, so will close this one.

@objectiser objectiser closed this Jan 23, 2019
@objectiser objectiser reopened this Jan 23, 2019
@objectiser
Copy link
Contributor Author

Sorry closed by mistake - kiali does need updated version in 1.1.

@istio-testing
Copy link
Collaborator

@objectiser: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/istio-pilot-multicluster-e2e.sh ea2f1d8 link /test istio-pilot-multicluster-e2e
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@linsun
Copy link
Member

linsun commented Jan 23, 2019

@wenchenglu @duderino can we get this approved for 1.1?

@wenchenglu
Copy link
Contributor

/lgtm
/approve

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, linsun, objectiser, wenchenglu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wenchenglu wenchenglu merged commit 0179045 into istio:release-1.1 Jan 23, 2019
hklai pushed a commit to hklai/istio that referenced this pull request Jan 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants