Fix productFlavor detection in embed submodules #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for problem discussed here : #348 Not sure if the strategy used is relevant, I'm a gradle task dev newbie
|
Thank you for your PR. I checked the code and made some changes. I will merge it soon. |
|
I just tested your changes this morning and can confirm it's working for the discussed use case (library projects embedded inside library projects with several productFlavors). Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for problem discussed here : #348
I'm a gradle task dev newbie so I'm not sure if the strategy used is relevant but it fixes the issue I'm facing