Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support missingDimensionStrategy without productFlavors in current project #343

Closed
Legion2 opened this issue Sep 17, 2021 · 1 comment · Fixed by #344
Closed

Support missingDimensionStrategy without productFlavors in current project #343

Legion2 opened this issue Sep 17, 2021 · 1 comment · Fixed by #344

Comments

@Legion2
Copy link
Contributor

Legion2 commented Sep 17, 2021

Currently missingDimensionStrategy is only supported in combination with productFlavors. However, if used in defaultConfig it is ignored.

For example:

android {
  defaultConfig {
    missingDimensionStrategy 'react-native-camera', 'general'
  }
}

dependencies {
    embed project(":react-native-camera")
}

here :react-native-camera will not be embeded without any error message.

The example is from https://react-native-camera.github.io/react-native-camera/docs/installation#android---other-required-steps

@Legion2
Copy link
Contributor Author

Legion2 commented Feb 25, 2022

I think #350 introduced a regression and broke my fix for this issue again. I tested with the v1.3.7 release and I get class not found exceptions for the classes of projects which have the missingDimensionStrategy set. If I use #344 I don't get the class not found exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant