Add tests for null relationship input #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/6nco619TiTUg42qXyb79Xy7nBgXd |
🦋 Changeset detectedLatest commit: 1e6fb0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
timleslie
force-pushed
the
null-relationship-test
branch
from
37d5a10 to
1e6fb0c
Compare
timleslie
changed the title
timleslie
requested review from
a team and
rohan-deshpande
and removed request for
a team and
rohan-deshpande
emmatown
approved these changes
Mar 4, 2021
This was referenced Mar 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relationship fields in
createandupdateoperations currently acceptnullas a valid GraphQL input. This is not currently handled correctly, see #5014 .This PR adds tests and clarifies that
nullinput is equivalent toundefinedinput, e.g. does not set or change the field value.In the future we might need to revisit whether we want to disallow
nullas an input value, or apply different semantics (e.g.nullbeing equivalent todisconnectAllin update). This PR is simply setting a well defined baseline to build on.