Remove protectIdentities from the createAuth API #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/51uSb7jrzw6b1nDJUj8wgrSAX4BB |
🦋 Changeset detectedLatest commit: 18b4876 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
timleslie
force-pushed
the
disable-protect-identities
branch
from
646ac29 to
fd2f8b7
Compare
timleslie
force-pushed
the
disable-protect-identities
branch
from
fd2f8b7 to
3b4dd62
Compare
JedWatson
approved these changes
Mar 3, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protectIdentities flag is currently under review to see whether it should be part of the createAuth API (in which case its use cases need to be documented and tested) or whether always being true is what we want, in which case we can refactor our code to match this.