Check x-forwarded-host before host for support reverse proxy defaults #4928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default setup of reverse proxies is to pass real host into `x-forwarded-host` key, with leaving `host` untouched. For not require special changes of reverse proxy settings to Keystone-next, I suggest to check it before `host`.
🦋 Changeset detectedLatest commit: edd133c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/9K55xXRaDyRZfkY3nxXMM5tm6vaE |
This was referenced Feb 23, 2021
timleslie
suggested changes
Feb 23, 2021
Co-authored-by: Tim Leslie <[email protected]>
Co-authored-by: Tim Leslie <[email protected]>
Co-authored-by: Tim Leslie <[email protected]>
timleslie
approved these changes
Feb 24, 2021
Merged
ghost
pushed a commit
to strativd/building-habits
that referenced
this pull request
Aug 13, 2021
- resolve proxy bug: keystonejs/keystone#4928
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default setup of reverse proxies is to pass real host into
x-forwarded-hostkey, with leavinghostuntouched.For not require special changes of reverse proxy settings to Keystone-next, I propose to check the
x-forwarded-hostbeforehost.Resolves #4902.