Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove back-ticks from inline code blocks #4925

Merged
merged 18 commits into from
Feb 23, 2021
Merged

Conversation

gwyneplaine
Copy link
Contributor

@gwyneplaine gwyneplaine commented Feb 23, 2021

Created a new InlineCode component which removes backticks from :before and :after pseudo-elements, as well as adding minor styling to <code> in mdx. See a preview of the change below

Screen Shot 2021-02-23 at 1 46 58 pm

@vercel
Copy link

vercel bot commented Feb 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/Du67YhYR9fQHfhv5bPs2EvZtzfdv
✅ Preview: https://keystone-next-docs-git-key-123-inline-code-block-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2021

🦋 Changeset detected

Latest commit: 6e27606

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gwyneplaine gwyneplaine force-pushed the KEY-123/inline-code-block branch from 180673c to 4af4114 Compare February 23, 2021 02:52
@vercel vercel bot temporarily deployed to Preview February 23, 2021 02:52 Inactive
@gwyneplaine gwyneplaine force-pushed the KEY-123/inline-code-block branch from 4af4114 to a1872f8 Compare February 23, 2021 02:52
@gwyneplaine gwyneplaine enabled auto-merge (squash) February 23, 2021 02:53
@gwyneplaine gwyneplaine disabled auto-merge February 23, 2021 02:55
@vercel vercel bot temporarily deployed to Preview February 23, 2021 02:55 Inactive
@vercel vercel bot temporarily deployed to Preview February 23, 2021 03:01 Inactive
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@gwyneplaine gwyneplaine merged commit 45d2b7c into master Feb 23, 2021
@gwyneplaine gwyneplaine deleted the KEY-123/inline-code-block branch February 23, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants