Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isAccessAllowed default #4923

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

emmatown
Copy link
Member

To test this, you can put this into an example, run it and see that you can access the Admin UI.

import { config, createSchema, list } from '@keystone-next/keystone/schema';
import { text, checkbox } from '@keystone-next/fields';

export default config({
  db: {
    adapter: 'mongoose',
    url: 'mongodb://localhost/keystone-basic-todo',
  },
  lists: createSchema({
    Todo: list({
      fields: {
        title: text({ isRequired: true }),
        isComplete: checkbox(),
      },
    }),
  }),
});

@vercel
Copy link

vercel bot commented Feb 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/Cvx2fsekgAvC6urxMyzomTZe3cCc
✅ Preview: https://keystone-next-git-key-174-fix-is-access-allowed-default-1bb188.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2021

🦋 Changeset detected

Latest commit: f8405e2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@keystone-next/admin-ui Major
@keystone-next/keystone Major
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-roles Patch
@keystone-next/example-todo Patch
@keystone-next/auth Major
@keystone-next/cloudinary Patch
@keystone-next/fields-document Patch
@keystone-next/fields Patch
@keystonejs/test-utils Patch
@keystonejs/benchmarks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,6 @@
---
'@keystone-next/admin-ui': major
'@keystone-next/keystone': major
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made this a major for both packages because it's changing access so just in case someone is relying on the current default of not having a session meaning they're not allowed access to the Admin UI, it won't suddenly change in a patch

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the example and was able to access the Admin UI 👍

@emmatown emmatown merged commit 1c5a399 into master Feb 23, 2021
@emmatown emmatown deleted the KEY-174/fix-is-access-allowed-default branch February 23, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants