Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix types for hooks #4905

Merged
merged 3 commits into from
Feb 21, 2021
Merged

Conversation

gautamsi
Copy link
Member

I found soem inconsistencies in the afterDelete and beforeDelete hook types.

found missing updatedItem in the hook for afterChange and beforeChange hook

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2021

🦋 Changeset detected

Latest commit: e113286

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/9LBEuYh7My7LoAyXREbPmUDvS2tb
✅ Preview: https://keystone-next-git-fork-gautamsi-missing-type-for-afterc-7c0bc1.vercel.app

@vercel vercel bot temporarily deployed to Preview February 21, 2021 11:50 Inactive
@gautamsi
Copy link
Member Author

@timleslie also found that there is no typings for authentication hooks

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catches, just one change as per comments below 👍

packages-next/types/src/config/hooks.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview February 21, 2021 21:46 Inactive
@gautamsi gautamsi requested a review from timleslie February 21, 2021 21:46
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vercel vercel bot temporarily deployed to Preview February 21, 2021 21:52 Inactive
@timleslie timleslie enabled auto-merge (squash) February 21, 2021 21:56
@timleslie timleslie merged commit 29e7879 into keystonejs:master Feb 21, 2021
@gautamsi gautamsi deleted the missing-type-for-afterChange branch February 21, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants