Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for custom search fields #4892

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Conversation

timleslie
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Feb 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/ogkblxcvp
✅ Preview: https://keystone-next-docs-git-custom-search-field.keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2021

🦋 Changeset detected

Latest commit: 7131347

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@keystonejs/adapter-knex Minor
@keystonejs/adapter-mongoose Minor
@keystonejs/adapter-prisma Minor
@keystone-next/website Minor
@keystone-next/keystone Minor
@keystone-next/types Minor
@keystonejs/api-tests Minor
@keystonejs/test-utils Patch
@keystone-next/auth Major
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-roles Patch
@keystone-next/example-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview February 19, 2021 03:07 Inactive
@vercel vercel bot temporarily deployed to Preview February 19, 2021 03:10 Inactive
@timleslie timleslie changed the title [WIP] Add configuration for custom search fields Add configuration for custom search fields Feb 19, 2021
@timleslie timleslie enabled auto-merge (squash) February 19, 2021 03:32
@timleslie timleslie merged commit 5d565ea into master Feb 19, 2021
@timleslie timleslie deleted the custom-search-field branch February 19, 2021 03:42
@vercel vercel bot temporarily deployed to Preview February 19, 2021 04:01 Inactive
@gautamsi
Copy link
Member

gautamsi commented Feb 19, 2021

I like this, there is one improvement I can think of a db config searchTemplate which can take a form of function or string literal which returns the query fragment based on search input. This way the search is very useful.

My customer wanted to search from make and model field from list, also the title of ecommerce items.
@JedWatson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants