Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the document field toolbar wrap #4883

Merged
merged 6 commits into from
Feb 19, 2021
Merged

Conversation

JedWatson
Copy link
Member

This change make the toolbar wrap when the viewport is small enough.

@mitchellhamilton I'm not sure why it was a grid in the first place, this doesn't seem to have changed anything else... I also removed the spacing, we could add it back but it looks fine and is slightly less likely to wrap this way

@vercel
Copy link

vercel bot commented Feb 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/b8hnov6dn
✅ Preview: https://keystone-next-docs-git-document-field-toolbar-wrap.keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2021

🦋 Changeset detected

Latest commit: e37c77b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-next/fields-document Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel vercel bot temporarily deployed to Preview February 18, 2021 13:24 Inactive
@vercel vercel bot temporarily deployed to Preview February 18, 2021 13:27 Inactive
@gautamsi
Copy link
Member

I also noticed that the document field on maximizing does not cover the full height of page. should that be fixed too?

@vercel vercel bot temporarily deployed to Preview February 18, 2021 23:08 Inactive
@vercel vercel bot temporarily deployed to Preview February 19, 2021 00:09 Inactive
@JedWatson JedWatson enabled auto-merge (squash) February 19, 2021 00:09
@JedWatson JedWatson merged commit d53eb87 into master Feb 19, 2021
@JedWatson JedWatson deleted the document-field-toolbar-wrap branch February 19, 2021 00:13
JedWatson added a commit that referenced this pull request Feb 22, 2021
* Fix toolbar layout issue for dropdowns, reverts #4883
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants