Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more generic types in access control #4875

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Conversation

timleslie
Copy link
Contributor

These changes will make this code agnostic to the arguments being passed to imperative access control functions.

@vercel
Copy link

vercel bot commented Feb 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/b3co96ndz
✅ Preview: https://keystone-next-docs-git-generic-access-control.keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2021

🦋 Changeset detected

Latest commit: 11cd327

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@keystonejs/access-control Major
@keystonejs/keystone Patch
@keystonejs/app-version Patch
@keystonejs/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This passes in access to the access control functions where it previously wasn't. I think it'd be better to have the functions in the access-control package accept { access: ..., args: Args } instead of { access: ... } & Args

@timleslie timleslie force-pushed the generic-access-control branch from d732557 to 6163caa Compare February 18, 2021 21:13
@vercel vercel bot temporarily deployed to Preview February 18, 2021 21:13 Inactive
@vercel vercel bot temporarily deployed to Preview February 18, 2021 21:22 Inactive
@timleslie timleslie force-pushed the generic-access-control branch from 1ad3d9c to c1c63c5 Compare February 18, 2021 21:24
@vercel vercel bot temporarily deployed to Preview February 18, 2021 21:25 Inactive
@timleslie timleslie force-pushed the generic-access-control branch from c1c63c5 to 2ccdcca Compare February 18, 2021 21:27
@vercel vercel bot temporarily deployed to Preview February 18, 2021 21:28 Inactive
@timleslie timleslie requested a review from emmatown February 18, 2021 22:21
@timleslie timleslie enabled auto-merge (squash) February 18, 2021 22:22
@vercel vercel bot temporarily deployed to Preview February 18, 2021 23:27 Inactive
@timleslie timleslie merged commit 891cd49 into master Feb 18, 2021
@timleslie timleslie deleted the generic-access-control branch February 18, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants