-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more generic types in access control #4875
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/b3co96ndz |
🦋 Changeset detectedLatest commit: 11cd327 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passes in access
to the access control functions where it previously wasn't. I think it'd be better to have the functions in the access-control package accept { access: ..., args: Args }
instead of { access: ... } & Args
d732557
to
6163caa
Compare
1ad3d9c
to
c1c63c5
Compare
c1c63c5
to
2ccdcca
Compare
Co-authored-by: Mitchell Hamilton <[email protected]>
These changes will make this code agnostic to the arguments being passed to imperative access control functions.