Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.ui.isDisabled option #4866

Merged
merged 4 commits into from
Feb 17, 2021
Merged

Add config.ui.isDisabled option #4866

merged 4 commits into from
Feb 17, 2021

Conversation

timleslie
Copy link
Contributor

In particular, this is needed for our testing framework, where we want to spin up an express server for just the graphQL API.

@vercel
Copy link

vercel bot commented Feb 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/mmc9i5is8
✅ Preview: https://keystone-next-docs-git-disable-admin-ui.keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2021

🦋 Changeset detected

Latest commit: bb162a9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@keystone-next/keystone Minor
@keystone-next/types Minor
@keystone-next/website Patch
@keystonejs/test-utils Patch
@keystone-next/auth Major
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-roles Patch
@keystone-next/example-todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be isDisabled as per #461, no?

@timleslie
Copy link
Contributor Author

It should be isDisabled as per #461, no?

Good point, it 💯 should. Will change 👍

@vercel vercel bot temporarily deployed to Preview February 17, 2021 03:25 Inactive
@timleslie timleslie requested a review from emmatown February 17, 2021 03:26
@emmatown emmatown changed the title Add config.ui.disabled option Add config.ui.isDisabled option Feb 17, 2021
@timleslie timleslie changed the title Add config.ui.isDisabled option [WIP] Add config.ui.isDisabled option Feb 17, 2021
@timleslie
Copy link
Contributor Author

Currently blocked on #4867

@vercel vercel bot temporarily deployed to Preview February 17, 2021 04:38 Inactive
@vercel vercel bot temporarily deployed to Preview February 17, 2021 04:41 Inactive
@vercel vercel bot temporarily deployed to Preview February 17, 2021 04:52 Inactive
@timleslie timleslie added blocked and removed blocked labels Feb 17, 2021
@vercel vercel bot temporarily deployed to Preview February 17, 2021 21:05 Inactive
@timleslie timleslie changed the title [WIP] Add config.ui.isDisabled option Add config.ui.isDisabled option Feb 17, 2021
@vercel vercel bot temporarily deployed to Preview February 17, 2021 21:18 Inactive
@timleslie timleslie requested a review from emmatown February 17, 2021 21:22
@vercel vercel bot temporarily deployed to Preview February 17, 2021 23:31 Inactive
@timleslie timleslie enabled auto-merge (squash) February 17, 2021 23:33
@vercel vercel bot temporarily deployed to Preview February 17, 2021 23:35 Inactive
@timleslie timleslie merged commit 2655c0b into master Feb 17, 2021
@timleslie timleslie deleted the disable-admin-ui branch February 17, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants