Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default values from validation functions #4861

Merged
merged 3 commits into from
Feb 16, 2021
Merged

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented Feb 16, 2021

Part of the effort to consolidate access control across keystone-5 and keystone-next.

@vercel
Copy link

vercel bot commented Feb 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/ntvl56ldq
✅ Preview: https://keystone-next-docs-git-access-args-types.keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2021

🦋 Changeset detected

Latest commit: 719080e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@keystonejs/access-control Major
@keystonejs/keystone Patch
@keystonejs/app-version Patch
@keystonejs/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -0,0 +1,6 @@
---
'@keystonejs/access-control': major
'@keystonejs/keystone': major
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this a major for @keystonejs/keystone?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, will change 👍

@vercel vercel bot temporarily deployed to Preview February 16, 2021 23:26 Inactive
@timleslie timleslie requested a review from emmatown February 16, 2021 23:26
@vercel vercel bot temporarily deployed to Preview February 16, 2021 23:36 Inactive
@timleslie timleslie enabled auto-merge (squash) February 16, 2021 23:37
@timleslie timleslie merged commit 6f985ac into master Feb 16, 2021
@timleslie timleslie deleted the access-args-types branch February 16, 2021 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants