Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all non ES5/ES Modules syntax from generated Admin UI files #4857

Merged

Conversation

emmatown
Copy link
Member

This is so that Keystone doesn't have an implicit dependency on the user's Babel config.

@vercel
Copy link

vercel bot commented Feb 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/8hmn3hhpd
✅ Preview: https://keystone-next-git-remove-all-non-es5-or-es-modules-synt-2e4cba.keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2021

🦋 Changeset detected

Latest commit: 717e77d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@keystone-next/admin-ui Major
@keystone-next/auth Major
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
@keystone-next/example-roles Patch
@keystone-next/example-todo Patch
@keystone-next/cloudinary Patch
@keystone-next/fields-document Patch
@keystone-next/fields Patch
@keystone-next/keystone Patch
@keystonejs/test-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vercel vercel bot temporarily deployed to Preview February 16, 2021 23:10 Inactive
@emmatown emmatown enabled auto-merge (squash) February 16, 2021 23:10
@emmatown emmatown merged commit c63e5d7 into master Feb 16, 2021
@emmatown emmatown deleted the remove-all-non-es5-or-es-modules-syntax-from-generated-files branch February 16, 2021 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants