Maintain session info on new contexts #4453
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of
context.createContext
in a fairly fundamental way: It now carries forwards the parameters that were used to create the originalcontext
object. This matches the behaviour we currently have implemented in the corecreateContext()
function. This results in what is arguably the "expected" behaviour, if you do:you will get a new context object which has the same session information as the original context. In the much less common case of this not being what you want you can always do:
I think changing the behaviour of
createContext
is a nicer solution that thecloneContext
function proposed in #4425.