Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add label resolver blog post #3933

Merged
merged 4 commits into from
Oct 13, 2020
Merged

Add label resolver blog post #3933

merged 4 commits into from
Oct 13, 2020

Conversation

Noviny
Copy link
Contributor

@Noviny Noviny commented Oct 12, 2020

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1cc8cba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@request-info
Copy link

request-info bot commented Oct 12, 2020

It looks like we could use some more details. Good titles and descriptions help us fix things faster. If you can provide more information please update this issue.

@JedWatson
Copy link
Member

Read through it @Noviny and it looks great 👍

Ready to go when we have screenshots in

@Noviny Noviny requested a review from JedWatson October 12, 2020 07:40
Noviny
Noviny commented Oct 12, 2020
View reviewed changes
docs/blog/better-ux-with-custom-labels.md
@@ -134,7 +138,7 @@ const Post = {
// and the rest of the fields too
},
labelResolver: async item => {
const { data } = await keystone.executeGraphQL({
const { data } = await Keystone.executeGraphQL({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JedWatson this conflicts with what we do in all our docsssss!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha whoops, that got caught in the search/replace for the case change. Wanna change it back?

@JedWatson
Copy link
Member

@Noviny I made some tweaks directly -

  • Consistent casing of "keystone" as "Keystone" and "admin UI" as "Admin UI"
  • Rewrote the "What is the Label?" section
  • Slight changes to tone of voice, simplified language
  • Fixed the slug for consistency and clearer url structure

@JedWatson JedWatson merged commit aa03ba3 into master Oct 13, 2020
@JedWatson JedWatson deleted the label-resolver-blog branch October 13, 2020 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JedWatson JedWatson JedWatson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Noviny @JedWatson