Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test AutoIncrement as both an ID and Int graphQL type #3744

Merged
merged 2 commits into from
Sep 22, 2020
Merged

Conversation

timleslie
Copy link
Contributor

We need to make sure that this field behaves correctly when used as both an ID and Int field in graphQL.

@changeset-bot
Copy link

changeset-bot bot commented Sep 22, 2020

💥 No Changeset

Latest commit: 330dc69

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

{ name: 'product6', orderNumber: 6 },
{ name: 'product7', orderNumber: 7 },
];
export const storedValues = matrixValue =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a strange name IMO since from reading the test, it's not actually the stored value, it's the value returned from graphql?

@timleslie timleslie merged commit cdd9fe8 into master Sep 22, 2020
@timleslie timleslie deleted the auto-inc-tests branch September 22, 2020 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants