Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listKey argument to hooks #3420

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Add listKey argument to hooks #3420

merged 1 commit into from
Aug 19, 2020

Conversation

timleslie
Copy link
Contributor

Writing generic plugins is difficult if you can't access the list name, so this PR makes the listKey available to all hook functions. This is useful for plugins like logging which need to be applied to many lists and want to know the name of the list.

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2020

🦋 Changeset is good to go

Latest commit: 4dd2129

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/keystone Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@timleslie timleslie force-pushed the add-list-key-to-hooks branch 2 times, most recently from 9b3b4fa to 574f112 Compare August 19, 2020 06:11
@timleslie timleslie requested a review from molomby August 19, 2020 06:14
@timleslie timleslie force-pushed the add-list-key-to-hooks branch from 574f112 to 22733a6 Compare August 19, 2020 22:40
@timleslie timleslie force-pushed the add-list-key-to-hooks branch from 22733a6 to 4dd2129 Compare August 19, 2020 23:00
Copy link
Member

@molomby molomby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to argue with that

@timleslie timleslie merged commit 25f50da into master Aug 19, 2020
@timleslie timleslie deleted the add-list-key-to-hooks branch August 19, 2020 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants