Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show Do Not Disturb permission prompt on devices that don't have the settings #1016

Closed
7 tasks done
medanisjbara opened this issue May 26, 2022 · 2 comments
Closed
7 tasks done
Assignees
Labels
bug Something isn't working

Comments

@medanisjbara
Copy link

medanisjbara commented May 26, 2022

Developer TODO (don't remove)

  • create new branch. put issue number at start of name if not a very quick fix.
  • write tests. put issue number in comment
  • update documentation
  • Doesn't seem to be an API to detect that a feature doesn't support it so just show a "never show again" button in the dialog. The AOSP Settings app seems to check this. This doesn't work because you need MANAGE_USERS permission and its only for system apps.
  • test on TV Don't require DND access for volume actions. #281
  • squash and merge
  • delete branch

Describe the bug
It seems like "Do Not Distrub access" is not available on Android Go (the same way "Display over other apps" (system alert window) isn't.
This results in

  • Key Mapper requireés permission to modify the Do Not Disturb mode if you want the button to work as expected in Do Not Disturb mode! error to show on top right after a trigger is recorded (when creating a keymap, screenshot 1). The fix button besides it does nothing on Android Go (screenshot 2) which looks really similar to "Display over other apps" on Android Go 10 (screenshot 3)
  • This trigger will not work as expected in Do Not Disturb mode! warning in every keymap created. (screenshot 4).
    I tested out a couple of functions in Do Not Disturb mode and they seem to work (which suggests that the warning and the error can be ignored).

To Reproduce
Install the app on Android Go 10 And create a keymap for one of the volume button (And possibly other buttons).

Expected behavior
Possible solutions can be:

  • A toast that tells you that "Do not disturb access doesn't work on your device" if the app detects Android Go. (And the error and the warning will not be shown again).
  • A dismiss button that will dismiss the unfixable error (under the fix button) which in it's turn dismiss all future warnings (Since the user cannot do anything to fix this).

Screenshots

  • Screenshot 1:
    Screenshot_1
  • Screenshot 2:
    Screenshot_2
  • Screenshot 3:
    Screenshot_3
  • Screenshot 4:
    Screenshot_4

Smartphone:

@medanisjbara medanisjbara added the bug Something isn't working label May 26, 2022
@sds100
Copy link
Collaborator

sds100 commented Jun 8, 2022

Thank you for this! I've seen this many times before but never have been sure why on certain devices it came up!

@sds100 sds100 changed the title Do not disturb mode in Android Go Don't show Do Not Disturb permission prompt on devices that don't have the settings Jun 9, 2022
sds100 added a commit that referenced this issue Jun 21, 2022
sds100 added a commit that referenced this issue Jun 21, 2022
sds100 added a commit that referenced this issue Jun 21, 2022
sds100 added a commit that referenced this issue Jun 21, 2022
sds100 added a commit that referenced this issue Jun 21, 2022
sds100 added a commit that referenced this issue Jun 21, 2022
@sds100
Copy link
Collaborator

sds100 commented Jun 21, 2022

implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants