Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not Disturb Permission request on device that has it disabled #1175

Closed
4 tasks
DominicBen opened this issue Oct 9, 2023 · 2 comments
Closed
4 tasks

Do not Disturb Permission request on device that has it disabled #1175

DominicBen opened this issue Oct 9, 2023 · 2 comments
Assignees
Labels
bug Something isn't working duplicate
Milestone

Comments

@DominicBen
Copy link

DominicBen commented Oct 9, 2023

Developer TODO (don't remove)

  • create new branch. put issue number at start of name if not a very quick fix.
  • test on Android TV emulator
  • update documentation
  • merge and delete branch (don't squash because want commit history to see why I made changes)

Describe the bug
My phone does not have built in volume buttons. When attempting to add the Action Volume up to any button, I am prompted to enable Do Not Distirb permissions for the app. My phone does not have do not disturb enabled, So i am redirected to the settings page, without anything changing

To Reproduce
Create Action to change volume, Bind to any function
When asked to fix Do not Disturb, click fix.
If do not disturb is disabled on your device, you our of luck.

Expected behavior
I expect the app to have some setting that would allow users to bypass this requirement if they do not have do not disturb as an available setting on their phone.

Screenshots
image

image

image

Smartphone (please complete the following information):

  • Device: 902kc
  • Android version: Android 8

#1016
This issue is somewhat related, but solves a problem with the volume buttons, rather than the volume action itself

Volume control works with other keymapping apps, but i personally really like this app, so i would love for this to work.

@DominicBen DominicBen added the bug Something isn't working label Oct 9, 2023
@BloodRaven0
Copy link

I'm not sure if it's related, but on Android TV 13, I can't map action to mute without this error message popping up. The keymap doesn't even try to send the command, it's just disabled, and clicking "fix" understandably returns an error that the DND menu wasn't found (ATV doesn't have such a menu).

@sds100 sds100 added this to the Version 2.6 milestone Jun 12, 2024
@sds100 sds100 moved this to Backlog in Key Mapper Jun 12, 2024
@sds100
Copy link
Collaborator

sds100 commented Jul 7, 2024

Duplicate of #526

@sds100 sds100 marked this as a duplicate of #526 Jul 7, 2024
@sds100 sds100 closed this as completed Jul 7, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Key Mapper Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate
Projects
Status: Done
Development

No branches or pull requests

3 participants