Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sil.km.gcc] Fix custom wordbreaker output (version bump to build) #276

Closed

Conversation

darcywong00
Copy link
Contributor

@darcywong00 darcywong00 commented Sep 16, 2024

This follows #265 which fixed the custom wordkbreaker output for sil.km.gcc. We held off on incrementing the version on that PR in anticipation of consolidating it with the repo-wide rebuild of #274.

@mcdurdin requested

Can we split the compiler version update into its own PR please? Then this becomes just maintenance, and issues such as the sil.lzz.laz update happening simultaneously to this won't have an impact.

So this PR will happen before #274 (which uses 17.0.329), so this build will happen with 17.0.328 stable compiler.

@mcdurdin
Copy link
Member

So this PR will happen before #274 (which uses 17.0.329), so this build will happen with 17.0.328 stable compiler.

Is there any need to push two updates? Can we just use #274 to wrap up both fixes and avoid having users download two updates?

@darcywong00
Copy link
Contributor Author

Can we split the compiler version update into its own PR please?

Ah, I had read that as isolating the kmc update from the rebuild of #265.

ok - we can abandon this and let #274 handle the rebuild of #265

@darcywong00 darcywong00 deleted the sil-km-gcc-wordbreaker-build branch September 16, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants