chore: Rebuild all models with kmc-17.0.329 to address missing low-frequency words #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcdurdin
requested changes
Sep 9, 2024
| @@ -1,6 +1,10 @@ | |||
| PhahTaigi POJ Lexical Model Change History | |||
| ==================== | |||
|
|
|||
| 1.1 (2024-09-09) | |||
| ---------------- | |||
| * Rebuild with 17.0.329 compiler | |||
There was a problem hiding this comment.
I think this needs to say why we are rebuilding with the updated compiler.
|
Waiting for @mcdurdin to review and give approval. |
|
Can we split the compiler version update into its own PR please? Then this becomes just maintenance, and issues such as the sil.lzz.laz update happening simultaneously to this won't have an impact. |
This was referenced Sep 16, 2024
mcdurdin
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
This file shouldn't be in this PR
There was a problem hiding this comment.
argh - I reverted package-lock.json but pushed to my fork instead of here. Will revert on a follow-on
There was a problem hiding this comment.
Don't worry about it. It doesn't do any harm as it stands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246
Update kmc to latest 17.0.329 stableThat was split out to kmc: Update compiler to 17.0.329 #277Also notes HISTORY.md file of sil.km.ggc for #265