Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ios): remove dead Swift-side keyboard gesture code #11672

Merged
merged 2 commits into from
Jun 7, 2024
Merged

chore(ios): remove dead Swift-side keyboard gesture code #11672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9cd9c9
chore(ios): remove dead Swift-side keyboard gesture code
Jun 4, 2024
105de3b
change(ios): move location of method definition
Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ios/engine/KMEI/KeymanEngine.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
archiveVersion = 1;
classes = {
};
objectVersion = 52;
objectVersion = 54;
objects = {

/* Begin PBXAggregateTarget section */
Expand Down Expand Up @@ -60,7 +60,6 @@
C0324B8F1F8750B700AF3785 /* TextView.swift in Sources */ = {isa = PBXBuildFile; fileRef = C0324B8E1F8750B700AF3785 /* TextView.swift */; };
C0324B911F8763E100AF3785 /* TextViewDelegateProxy.swift in Sources */ = {isa = PBXBuildFile; fileRef = C0324B901F8763E100AF3785 /* TextViewDelegateProxy.swift */; };
C0324B931F87689B00AF3785 /* KeymanURLProtocol.swift in Sources */ = {isa = PBXBuildFile; fileRef = C0324B921F87689B00AF3785 /* KeymanURLProtocol.swift */; };
C040E50E1F85FF8A00901EE4 /* KeyPreviewView.swift in Sources */ = {isa = PBXBuildFile; fileRef = C040E50D1F85FF8A00901EE4 /* KeyPreviewView.swift */; };
C040E5101F8606E300901EE4 /* TextField.swift in Sources */ = {isa = PBXBuildFile; fileRef = C040E50F1F8606E300901EE4 /* TextField.swift */; };
C040E5121F86107E00901EE4 /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = C040E5111F86107E00901EE4 /* AppDelegate.swift */; };
C040E5141F86108900901EE4 /* MainViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = C040E5131F86108900901EE4 /* MainViewController.swift */; };
Expand All @@ -76,7 +75,6 @@
C06D37341F81F5C300F61AE0 /* HTTPDownloader.swift in Sources */ = {isa = PBXBuildFile; fileRef = C0ED71B41F6BBFAF002A2FD6 /* HTTPDownloader.swift */; };
C06D37351F81F5C300F61AE0 /* HTTPDownloadRequest.swift in Sources */ = {isa = PBXBuildFile; fileRef = C0ED71B21F6BB0B1002A2FD6 /* HTTPDownloadRequest.swift */; };
C06D37361F81F5C300F61AE0 /* KeyboardMenuView.swift in Sources */ = {isa = PBXBuildFile; fileRef = C034BBBD1F7CCE7D00021FF5 /* KeyboardMenuView.swift */; };
C06D37381F81F5C400F61AE0 /* SubKeysView.swift in Sources */ = {isa = PBXBuildFile; fileRef = C07B42AE1F7CEE2700ECA97F /* SubKeysView.swift */; };
C06D37421F81F5C400F61AE0 /* KeyboardPickerButton.swift in Sources */ = {isa = PBXBuildFile; fileRef = C08C620F1F67BD4500268D03 /* KeyboardPickerButton.swift */; };
C06D37431F81F5C400F61AE0 /* KeyboardPickerBarButtonItem.swift in Sources */ = {isa = PBXBuildFile; fileRef = C08C620B1F6792A200268D03 /* KeyboardPickerBarButtonItem.swift */; };
C06D37441F81F5C400F61AE0 /* KeyboardNameTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = C08C62121F67C31100268D03 /* KeyboardNameTableViewCell.swift */; };
Expand Down Expand Up @@ -378,7 +376,6 @@
C0324B901F8763E100AF3785 /* TextViewDelegateProxy.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextViewDelegateProxy.swift; sourceTree = "<group>"; };
C0324B921F87689B00AF3785 /* KeymanURLProtocol.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = KeymanURLProtocol.swift; sourceTree = "<group>"; };
C034BBBD1F7CCE7D00021FF5 /* KeyboardMenuView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = KeyboardMenuView.swift; sourceTree = "<group>"; };
C040E50D1F85FF8A00901EE4 /* KeyPreviewView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = KeyPreviewView.swift; sourceTree = "<group>"; };
C040E50F1F8606E300901EE4 /* TextField.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextField.swift; sourceTree = "<group>"; };
C040E5111F86107E00901EE4 /* AppDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AppDelegate.swift; sourceTree = "<group>"; };
C040E5131F86108900901EE4 /* MainViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MainViewController.swift; sourceTree = "<group>"; };
Expand All @@ -395,7 +392,6 @@
C06D372B1F81F4E100F61AE0 /* KeymanEngine.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = KeymanEngine.framework; sourceTree = BUILT_PRODUCTS_DIR; };
C06D372E1F81F4E100F61AE0 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
C075EB051F8EFF870041F4BD /* String+Helpers.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "String+Helpers.swift"; sourceTree = "<group>"; };
C07B42AE1F7CEE2700ECA97F /* SubKeysView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SubKeysView.swift; sourceTree = "<group>"; };
C082CE141F90AFD400860F02 /* Collection+SafeAccess.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "Collection+SafeAccess.swift"; sourceTree = "<group>"; };
C08C620B1F6792A200268D03 /* KeyboardPickerBarButtonItem.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = KeyboardPickerBarButtonItem.swift; sourceTree = "<group>"; };
C08C620F1F67BD4500268D03 /* KeyboardPickerButton.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = KeyboardPickerButton.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -796,9 +792,7 @@
CE79B24823C711FF007E72AE /* KeyboardScaleMap.swift */,
C0EF3E7A1F95B65300CE9BD4 /* KeymanWebDelegate.swift */,
C0C16A881FA8146300F090BA /* KeymanWebViewController.swift */,
C040E50D1F85FF8A00901EE4 /* KeyPreviewView.swift */,
C0A5FF361F6682EB00BE740C /* PopoverView.swift */,
C07B42AE1F7CEE2700ECA97F /* SubKeysView.swift */,
);
path = Keyboard;
sourceTree = "<group>";
Expand Down Expand Up @@ -1454,7 +1448,6 @@
CE7A26DB23CEEF640005955C /* Colors.swift in Sources */,
9A9CB08022416E5400231FB9 /* LexicalModelPickerViewController.swift in Sources */,
9A079E3D223B5FAF00581263 /* InstallableLexicalModel.swift in Sources */,
C06D37381F81F5C400F61AE0 /* SubKeysView.swift in Sources */,
C0A93A541F8B21240079948B /* Manager.swift in Sources */,
CE99350E24D7CCFC00202DA3 /* LanguagePickAssociator.swift in Sources */,
C024C9981FA6F2340060583B /* NotificationObserver.swift in Sources */,
Expand All @@ -1468,7 +1461,6 @@
9A3E832522EAC14A00D22D2A /* KeyboardSwitcherViewController.swift in Sources */,
C0324B911F8763E100AF3785 /* TextViewDelegateProxy.swift in Sources */,
C0B09EAE1FCFD10F002F39AF /* FontManager.swift in Sources */,
C040E50E1F85FF8A00901EE4 /* KeyPreviewView.swift in Sources */,
CEC0C6772410E049003E1BCD /* SentryManager.swift in Sources */,
9A079E3A223AFF3C00581263 /* KeyboardKeymanPackage.swift in Sources */,
C0CB633C1FA6F61500617CDB /* Notifications.swift in Sources */,
Expand Down
4 changes: 0 additions & 4 deletions ios/engine/KMEI/KeymanEngine/Classes/Keyboard/InputViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,6 @@ open class InputViewController: UIInputViewController, KeymanWebDelegate {
}

func insertText(_ keymanWeb: KeymanWebViewController, numCharsToDelete: Int, newText: String) {
if keymanWeb.isSubKeysMenuVisible {
return
}

if isInputClickSoundEnabled {
UIDevice.current.playInputClick()

Expand Down
185 changes: 0 additions & 185 deletions ios/engine/KMEI/KeymanEngine/Classes/Keyboard/KeyPreviewView.swift
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions ios/engine/KMEI/KeymanEngine/Classes/Keyboard/KeymanWebDelegate.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,23 +21,6 @@ protocol KeymanWebDelegate: class {
/// - Parameters:
func beep(_ keymanWeb: KeymanWebViewController)

/// - Parameters:
/// - keyFrame: The frame of the anchor key.
/// - preview: The text to preview.
func showKeyPreview(_ keymanWeb: KeymanWebViewController, keyFrame: CGRect, preview: String)

func dismissKeyPreview(_ keymanWeb: KeymanWebViewController)

/// - Parameters:
/// - keyFrame: The frame of the anchor key.
/// - subkeyIDs: The IDs of the subkeys.
/// - subkeyTexts: The user-displayable texts of the subkeys.
/// - useSpecialFont: Use the Keyman Web OSK font.
func showSubkeys(_ keymanWeb: KeymanWebViewController,
keyFrame: CGRect,
subkeyIDs: [String],
subkeyTexts: [String],
useSpecialFont: Bool)
func menuKeyDown(_ keymanWeb: KeymanWebViewController)
func menuKeyUp(_ keymanWeb: KeymanWebViewController)
func menuKeyHeld(_ keymanWeb: KeymanWebViewController)
Expand All @@ -47,13 +30,6 @@ extension KeymanWebDelegate {
func keyboardLoaded(_ keymanWeb: KeymanWebViewController) {}
func insertText(_ keymanWeb: KeymanWebViewController, numCharsToDelete: Int, newText: String) {}
func beep(_ keymanWeb: KeymanWebViewController) {}
func showKeyPreview(_ keymanWeb: KeymanWebViewController, keyFrame: CGRect, preview: String) {}
func dismissKeyPreview(_ keymanWeb: KeymanWebViewController) {}
func showSubkeys(_ keymanWeb: KeymanWebViewController,
keyFrame: CGRect,
subkeyIDs: [String],
subkeyTexts: [String],
useSpecialFont: Bool) {}
func menuKeyDown(_ keymanWeb: KeymanWebViewController) {}
func menuKeyUp(_ keymanWeb: KeymanWebViewController) {}
func menuKeyHeld(_ keymanWeb: KeymanWebViewController) {}
Expand Down
Loading
Loading