-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ios): remove dead Swift-side keyboard gesture code #11672
Conversation
User Test ResultsTest specification and instructions
Test Artifacts
|
708fe8a
to
105de3b
Compare
Test Results
I tested the gesture features, such as "long press," "flick," and "multitap". I can hold the key and select a letter from the submenu. Caplock is enabled after pressing the "shift" key multiple times. "Long press" and "Multitap" are working fine. Flick is working when you slide down the key. It works well. Thank you. |
Changes in this pull request will be available for download in Keyman version 18.0.51-alpha |
This PR removes what is essentially dead code.
While working on a different PR this sprint, I remembered that way back in the past, with #2959, we changed the iOS keyboard engine to use the Web-based subkey menu. At the time, we hoped that what we saw as a bug would be fixed and that we'd be able to reverse the decision. A lot has changed since then, and we're now fully committed to handling all keyboard gestures fully on the JS side, within the WebView... so there's no longer any real reason to keep this code around.
Note that the Swift-side gesture handlers actually are still connected... but the functionality they exist to facilitate never utilizes them.
I originally thought this might be related to #11650, but it turned out to have a different underlying cause. Still... being able to delete over 800 lines of code is pretty significant.
User Testing
TEST_GENERAL_USE: do some general testing of the Keyman app for iOS and its system keyboard; things should work the same as usual.