Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): validate in editor if subflow with namespace present #6717

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

aabhas-sao
Copy link
Contributor

What changes are being made and why?

  • added validation for subflows in task are present with the mentioned namespace.
  • validation runs when saving the file and making any changes in editor.

closes #2087


How the changes have been QAed?

Tested changes locally on a standalone server. please screen recording below.

kestra_subflows.mp4

@MilosPaunovic MilosPaunovic self-requested a review January 10, 2025 21:52
@MilosPaunovic MilosPaunovic self-assigned this Jan 10, 2025
@MilosPaunovic MilosPaunovic requested review from Skraye and removed request for MilosPaunovic January 10, 2025 21:53
@MilosPaunovic MilosPaunovic assigned Skraye and unassigned MilosPaunovic and Skraye Jan 10, 2025
@MilosPaunovic MilosPaunovic removed the request for review from Skraye January 16, 2025 12:31
@Skraye Skraye self-requested a review January 20, 2025 09:00
@Skraye Skraye merged commit 4b2c10d into kestra-io:develop Jan 20, 2025
7 of 8 checks passed
@Skraye
Copy link
Member

Skraye commented Jan 20, 2025

Good job, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Subflow validation on edit
3 participants