Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subflow validation on edit #2087

Closed
brian-mulier-p opened this issue Sep 12, 2023 · 7 comments · Fixed by #6717
Closed

Subflow validation on edit #2087

brian-mulier-p opened this issue Sep 12, 2023 · 7 comments · Fixed by #6717
Assignees
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors

Comments

@brian-mulier-p
Copy link
Member

Feature description

Would be great that subflows are validated (ie checked that they exist) on flow editing just to know there's a typo or something (currently we won't have any feedback except in console when a subflow doesn't exist and we try to expand it)

@brian-mulier-p brian-mulier-p added area/backend Needs backend code changes enhancement New feature or request labels Sep 12, 2023
@github-project-automation github-project-automation bot moved this to Backlog in All issues Sep 12, 2023
@anna-geller anna-geller added this to the v0.17.0 milestone Dec 5, 2023
@anna-geller anna-geller removed this from All issues Dec 12, 2023
@anna-geller anna-geller modified the milestones: v0.17.0, v0.22.0 Apr 10, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Jun 10, 2024
@anna-geller anna-geller removed this from the v0.22.0 milestone Jul 23, 2024
@anna-geller anna-geller added the area/frontend Needs frontend code changes label Aug 19, 2024
@anna-geller anna-geller added the good first issue Great issue for new contributors label Oct 10, 2024
@anna-geller
Copy link
Member

For external contributors: what it means is that trying to Save the following flow should work (because hello_world flow in tutorial namespace exists by default):

id: myflow
namespace: tutorial
tasks:
  - id: hello
    type: io.kestra.plugin.core.flow.Subflow
    namespace: tutorial
    flowId: hello_world

but trying to save this flow should not work as this flowId doesn't exist in the tutorial namespace:

id: myflow
namespace: tutorial
tasks:
  - id: hello
    type: io.kestra.plugin.core.flow.Subflow
    namespace: tutorial
    flowId: non_existing_flow_id

@SyedMDot
Copy link

SyedMDot commented Oct 12, 2024

Hi, I want to contribute to this issue. could you please assign this to me? @anna-geller

@Ben8t
Copy link
Member

Ben8t commented Oct 16, 2024

@SyedMDot did you get the chance to move forward on this issue ?

@SyedMDot
Copy link

Hi I was working on below issue, and just submitted a video to confirm weather my solution is as expected or not.

I'll start this now.

#3112

@SyedMDot SyedMDot removed their assignment Oct 16, 2024
@aabhas-sao
Copy link
Contributor

Hi @anna-geller,
is anyone working on this issue. If not I would love to pick this up 🙂

@MilosPaunovic
Copy link
Member

Absolutely, go for it @aabhas-sao! 🚀

@aabhas-sao
Copy link
Contributor

Hi @MilosPaunovic,
I have raised one PR, please check it out. If any changes required. If validation is done in right places, or need to add to more places.

@MilosPaunovic MilosPaunovic moved this from Backlog to In review in Issues Jan 16, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Issues Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants