Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor usage of Display class into Oracle #959

Merged
merged 7 commits into from
Oct 10, 2023
Merged

Refactor usage of Display class into Oracle #959

merged 7 commits into from
Oct 10, 2023

Conversation

haifeng-jin
Copy link
Collaborator

@haifeng-jin haifeng-jin commented Oct 10, 2023

To avoid the Display to call the chief from a client after calling end_trial() on the last trial, which would requie the chief to wait even all the trials were reported to be finished, we refactor the Display class into the Oracle.
Now, no client would print logs, but only the chief would do.

Another important change is that the chief would start to block when calling search(). It used to block in __init__().

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (354b2cb) 97.60% compared to head (ee81678) 97.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           timeout     #959      +/-   ##
===========================================
+ Coverage    97.60%   97.61%   +0.01%     
===========================================
  Files           50       50              
  Lines         3086     3107      +21     
===========================================
+ Hits          3012     3033      +21     
  Misses          74       74              
Files Coverage Δ
keras_tuner/engine/base_tuner.py 100.00% <100.00%> (ø)
keras_tuner/engine/oracle.py 100.00% <100.00%> (ø)
keras_tuner/engine/tuner_utils.py 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@haifeng-jin haifeng-jin changed the base branch from master to timeout October 10, 2023 05:31
Base automatically changed from timeout to master October 10, 2023 20:03
@haifeng-jin haifeng-jin merged commit 9b648f7 into master Oct 10, 2023
8 checks passed
@haifeng-jin haifeng-jin deleted the display branch October 10, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant