Refactor usage of Display class into Oracle #959
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid the
Display
to call the chief from a client after callingend_trial()
on the last trial, which would requie the chief to wait even all the trials were reported to be finished, we refactor theDisplay
class into theOracle
.Now, no client would print logs, but only the chief would do.
Another important change is that the chief would start to block when calling
search()
. It used to block in__init__()
.