Skip to content

Fixes GPU Test failures for Keras 3 #1361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fixes GPU Test failures for Keras 3 #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eadc254
Update Keras2 to TF 2.15 to align on cuda ver
sampathweb Dec 12, 2023
6fb5da0
Set encoding to utf8 for tokenizer
sampathweb Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .kokoro/github/ubuntu/gpu/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ if [ "${KERAS2:-0}" == "1" ]
then
echo "Keras2 detected."
pip install -r requirements-common.txt --progress-bar off
pip install tensorflow-text==2.14 tensorflow==2.14 keras-core
pip install tensorflow-text==2.15 tensorflow[and-cuda]~=2.15 keras-core

elif [ "$KERAS_BACKEND" == "tensorflow" ]
then
Expand Down
5 changes: 5 additions & 0 deletions .kokoro/github/ubuntu/gpu/keras2/presubmit.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,10 @@ action {
}
}

env_vars: {
key: "KERAS2"
value: "1"
}

# Set timeout to 60 mins from default 180 mins
timeout_mins: 60
2 changes: 1 addition & 1 deletion keras_nlp/models/whisper/whisper_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

def _load_dict(dict_or_path):
if isinstance(dict_or_path, str):
with open(dict_or_path, "r") as f:
with open(dict_or_path, "r", encoding="utf-8") as f:
dict_or_path = json.load(f)
return dict_or_path

Expand Down
2 changes: 1 addition & 1 deletion keras_nlp/tokenizers/byte_pair_tokenizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def __init__(
super().__init__(dtype=dtype, **kwargs)

if isinstance(vocabulary, str):
with open(vocabulary, "r") as f:
with open(vocabulary, "r", encoding="utf-8") as f:
self.vocabulary = json.load(f)
elif isinstance(vocabulary, dict):
self.vocabulary = vocabulary.copy()
Expand Down