Fixes GPU Test failures for Keras 3 #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampathweb
changed the title
Member
|
Thank you for the PR! It looks like the failing Keras2 GPU test is being skipped on Keras2 CPU but passes for Keras3 on GPU. Overal LGTM but should we fix the final test before merging or is that a follow-up? |
nkovela1
approved these changes
Dec 12, 2023
Collaborator
nkovela1
left a comment
nkovela1
left a comment
There was a problem hiding this comment.
Thank you Ramesh! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GPU Tests for Keras 3 for all backends are now passing.
There's one test failure on T5 saving for Keras 2