Skip to content

Fix saved-package search test schema and select for the hidden column - #749

Closed
kody-bot wants to merge 1 commit into
mainfrom
cursor/fix-repo-search-test-hidden-column-ee05
Closed

kody-bot wants to merge 1 commit into
mainfrom
cursor/fix-repo-search-test-hidden-column-ee05

Conversation

@kody-bot

@kody-bot kody-bot commented Jul 13, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the main-branch Validate failure introduced by the concurrent merges of #745 and #746.

What happened

Fix

  • Add the hidden column to the test schema and buildRow (with a satisfies check against the insertSavedPackage row type so future column drift fails typecheck).
  • Include hidden in the searchSavedPackagesByUserId SELECT so browse results report real visibility instead of always false.

Testing

  • npm run validate fully green locally on this branch (format, lint, typecheck, 856 unit tests, 14 Playwright E2E, MCP E2E).

Summary by CodeRabbit

  • Bug Fixes
    • Fixed saved package searches so hidden package status is preserved correctly in returned results.
    • Ensured paginated saved package listings accurately reflect whether each package is hidden or visible.

PRs #745 and #746 merged concurrently: #745 added repo-search.workers.test.ts with a saved_packages test schema, and #746 added the required hidden column to SavedPackageRow and insertSavedPackage. Combined on main, the test suite failed with 'table saved_packages has no column named hidden'. Add the column to the test schema and buildRow, and include hidden in the searchSavedPackagesByUserId select so browse results report real visibility.
@kody-bot
kody-bot deployed to preview-749 July 13, 2026 23:02 — with GitHub Actions Active
@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0bd229d0-1986-4a17-ac86-89c6af2e863f

📥 Commits

Reviewing files that changed from the base of the PR and between d857526 and 978b9f0.

📒 Files selected for processing (2)
  • packages/worker/src/package-registry/repo-search.workers.test.ts
  • packages/worker/src/package-registry/repo.ts

📝 Walkthrough

Walkthrough

The saved-package test schema and row builder now support hidden, while searchSavedPackagesByUserId selects the column so mapped search results retain its value.

Changes

Saved package hidden state

Layer / File(s) Summary
Hidden column test contract
packages/worker/src/package-registry/repo-search.workers.test.ts
The test schema adds a constrained hidden column, and buildRow accepts and converts an optional boolean into the stored integer value with parameter type checking.
Search hidden-column projection
packages/worker/src/package-registry/repo.ts
The saved-package items query selects hidden for mapping into returned records.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: kentcdodds

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main fix: adding the hidden column to the test schema and selecting it in saved-package search.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-repo-search-test-hidden-column-ee05

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🔎 Preview deployed: https://kody-pr-749.kody-a99.workers.dev

Worker: kody-pr-749
D1: kody-pr-749-db
KV: kody-pr-749-oauth-kv

Mocks:

@kody-bot

Copy link
Copy Markdown
Collaborator Author

Closing: #748 landed the identical fix (same test-schema column, buildRow hidden field, and hidden in the search SELECT) while this PR was in CI.

@kody-bot kody-bot closed this Jul 13, 2026
@cursor
cursor Bot deleted the cursor/fix-repo-search-test-hidden-column-ee05 branch July 13, 2026 23:10

This branch was successfully deployed

1 active deployment
preview-749 — 978b9f04 Deployed Jul 13, 2026 by kody-bot via 🔎 Deploy Preview Resources #3405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants