Conversation
PRs #745 and #746 merged concurrently: #745 added repo-search.workers.test.ts with a saved_packages test schema, and #746 added the required hidden column to SavedPackageRow and insertSavedPackage. Combined on main, the test suite failed with 'table saved_packages has no column named hidden'. Add the column to the test schema and buildRow, and include hidden in the searchSavedPackagesByUserId select so browse results report real visibility.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe saved-package test schema and row builder now support ChangesSaved package hidden state
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🔎 Preview deployed: https://kody-pr-749.kody-a99.workers.dev Worker: Mocks:
|
|
Closing: #748 landed the identical fix (same test-schema column, buildRow hidden field, and hidden in the search SELECT) while this PR was in CI. |
Fixes the main-branch Validate failure introduced by the concurrent merges of #745 and #746.
What happened
repo-search.workers.test.tswith a localsaved_packagestest schema.hiddencolumn toSavedPackageRowandinsertSavedPackage.mainthe workers-unit suite fails withD1_ERROR: table saved_packages has no column named hidden(see the Validate run ford857526a).Fix
hiddencolumn to the test schema andbuildRow(with asatisfiescheck against theinsertSavedPackagerow type so future column drift fails typecheck).hiddenin thesearchSavedPackagesByUserIdSELECT so browse results report real visibility instead of alwaysfalse.Testing
npm run validatefully green locally on this branch (format, lint, typecheck, 856 unit tests, 14 Playwright E2E, MCP E2E).Summary by CodeRabbit