Skip to content

Fix repo-search workers test for saved_packages hidden column - #748

Merged
kody-bot merged 1 commit into
mainfrom
cursor/fix-packages-hidden-column-db5c
Jul 13, 2026
Merged

kody-bot merged 1 commit into
mainfrom
cursor/fix-packages-hidden-column-db5c

Conversation

@kentcdodds

Copy link
Copy Markdown
Owner

What

Fixes the main CI failure from the semantic merge conflict between #745 and #746: repo-search.workers.test.ts (added in #745) created its own saved_packages test schema without the hidden column that #746's migration added, so insertSavedPackage failed with table saved_packages has no column named hidden once both landed.

  • Adds the hidden column to the test schema and seed rows (mirroring community-flow-test-schema.ts).
  • Includes hidden in the searchSavedPackagesByUserId SELECT so returned records carry the real visibility flag instead of always mapping to false.

Testing

  • npm run test (node + workers unit suites) passes on latest main plus this fix, including the previously failing repo-search.workers.test.ts.
  • npm run typecheck, npm run lint, npm run format:check pass.
System recap — composes existing primitives (low risk)

Mode: recap · Base: main @ d857526a · Head: c83ff92b

Classification: composes — test-schema fix plus one added column in an existing read query; no contracts change.

Primitives touched

Primitive Group Impact
saved-packages assistant composes — searchSavedPackagesByUserId SELECT now includes hidden; workers test schema matches migration 0058
Open in Web Open in Cursor 

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kentcdodds, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9a4ba5aa-df3c-435e-947e-9b557e67cc3b

📥 Commits

Reviewing files that changed from the base of the PR and between d857526 and c83ff92.

📒 Files selected for processing (2)
  • packages/worker/src/package-registry/repo-search.workers.test.ts
  • packages/worker/src/package-registry/repo.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/fix-packages-hidden-column-db5c

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🔎 Preview deployed: https://kody-pr-748.kody-a99.workers.dev

Worker: kody-pr-748
D1: kody-pr-748-db
KV: kody-pr-748-oauth-kv

Mocks:

@kody-bot
kody-bot merged commit 6a33acb into main Jul 13, 2026
5 checks passed
@kody-bot
kody-bot deleted the cursor/fix-packages-hidden-column-db5c branch July 13, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants