Skip to content

Conversation

@Andarist
Copy link
Contributor

Main focus of this PR is to use @babel/runtime helpers instead of including their copy in distributed sources.

Motivation
Shipping less code - by using @babel/runtime helpers we are able to deduplicate their code across all dependencies using them.

@Andarist Andarist force-pushed the use-runtime-helpers branch from 9dc4f29 to 123c3c0 Compare October 11, 2018 08:43
@Andarist Andarist force-pushed the use-runtime-helpers branch from 123c3c0 to ddfda14 Compare October 11, 2018 08:43
Copy link
Owner

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 👍 Thanks!

@kentcdodds kentcdodds merged commit 8337bbd into kentcdodds:master Oct 11, 2018
@kentcdodds
Copy link
Owner

Oh, I just had a thought. For UMD I think we should be bundling @babel/runtime right? Is this doing that?

@kentcdodds
Copy link
Owner

🎉 This PR is included in version 0.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Andarist
Copy link
Contributor Author

@kentcdodds it's advised to add @babel/runtime as dependency and rollup.config.js is configured to bundle dependencies, so it should be ok :) you'll be able to see that it's working ok in a minute in downshift :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants