-
Notifications
You must be signed in to change notification settings - Fork 943
chore(tooling): update kcd-scripts #600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kentcdodds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Could you verify for me that the umd bundle has the @babel/runtime dep bundled?
|
UMD function _objectWithoutPropertiesLoose(source, excluded) {
// ...
}
function _extends() {
// ..
}ESM import computeScrollIntoView from 'compute-scroll-into-view';
import _objectWithoutPropertiesLoose from '@babel/runtime/helpers/esm/objectWithoutPropertiesLoose';
import _extends from '@babel/runtime/helpers/esm/extends';
import _inheritsLoose from '@babel/runtime/helpers/esm/inheritsLoose';
import _assertThisInitialized from '@babel/runtime/helpers/esm/assertThisInitialized';
import React, { Component } from 'react';
import PropTypes from 'prop-types'; |
|
Tests are wrongly configured though (might be because of kcd-scripts upgrade) - gonna take a look soon & ping you once I fix it. |
|
Thanks! |
ffabe2e to
407c0f5
Compare
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 3 3
Lines 366 366
Branches 92 92
=====================================
Hits 366 366Continue to review full report at Codecov.
|
kentcdodds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolio. Thanks!
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Motivation
kentcdodds/kcd-scripts#71