[codex] replace Karabiner with Kanary - #893
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughKarabiner Elements is removed as the keyboard remapping tool. The ChangesKarabiner → Kanary migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
test/nix-darwin-config.test.jsOops! Something went wrong! :( ESLint: 10.5.0 ReferenceError: describe is not defined Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d3d6c1d to
1b1fbfb
Compare
1b1fbfb to
11b20fa
Compare
最新のmainブランチ(PR #893 でKarabiner→Kanary置換済み)の変更を取り込み マージコンフリクトを解消する。 - nix/home/karabiner.nix を削除(Kanaryに置換済み) - nix/home/default.nix からkarabiner.nixのインポートを削除 - nix/hosts/darwin/default.nix にkanary.nixのインポートを追加 - nix/modules/homebrew.nix からkarabiner-elementsを削除 - nix/modules/kanary.nix を追加(Kanary要件チェック) - docs/adr/0016-use-kanary-for-keyboard-remapping.md を追加 - script/macos/agent-select-input-source.sh を復元 - script/macos/select-input-source.swift を復元 - test/nix-darwin-config.test.js をKanary対応バージョンに更新 Co-authored-by: keito4 <keito4@users.noreply.github.com>
|
🎉 This PR is included in version 1.119.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
karabiner-elementsand stop importing/deployingnix/home/karabiner.nix.system.checksguard that fails before Homebrew activation ifKanary.appis not installed in/Applicationsor~/Applications.Impact
darwin-rebuild switch --flake ~/develop/github.com/keito4/config/nixno longer installs or manages Karabiner. Kanary remains a manual install fromhttps://kanary.download/downloaduntil a stable package-manager source exists, but rebuild now fails before Homebrew cleanup if Kanary is missing so keyboard remapping does not silently disappear.Validation
npm test -- --runTestsByPath test/nix-darwin-config.test.jsnpm run format:checknix eval ./nix#darwinConfigurations.keitos-MacBook-Pro.config.system.checks.textSummary by CodeRabbit
New Features
Bug Fixes