Skip to content

Fix cmux IME shortcuts via Karabiner input source selector - #881

Closed
keito4 wants to merge 3 commits into
mainfrom
codex/cmux-external-terminal-links
Closed

keito4 wants to merge 3 commits into
mainfrom
codex/cmux-external-terminal-links

Conversation

@keito4

@keito4 keito4 commented Jun 22, 2026

Copy link
Copy Markdown
Owner

Summary

  • switch cmux IME shortcuts from virtual kana/eisu keys to Karabiner's built-in select_input_source action
  • keep Caps Lock as Ctrl and include left/right Ctrl plus Caps Lock shortcut variants
  • set the Karabiner virtual keyboard type to ANSI to avoid the keyboard type prompt and JIS key drift on the external keyboard

Verification

  • npm test -- --runTestsByPath test/nix-darwin-config.test.js
  • npm run format:check
  • npm run lint
  • karabiner_cli --lint-complex-modifications .context/karabiner.generated.json
  • karabiner_cli --lint-complex-modifications /Users/keito/.config/karabiner/karabiner.json

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@github-actions[bot], we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 45 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 55add99a-03ae-40d8-9858-119d5db11dec

📥 Commits

Reviewing files that changed from the base of the PR and between 1400335 and 628a15f.

📒 Files selected for processing (8)
  • docs/adr/0016-use-kanary-for-keyboard-remapping.md
  • nix/home/default.nix
  • nix/home/karabiner.nix
  • nix/hosts/darwin/default.nix
  • nix/modules/homebrew.nix
  • nix/modules/kanary.nix
  • script/macos/agent-select-input-source.sh
  • test/nix-darwin-config.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/cmux-external-terminal-links

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@keito4
keito4 force-pushed the codex/cmux-external-terminal-links branch from ad0a770 to 87bdf8c Compare June 22, 2026 07:58
@claude

claude Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keito4's task in 0s —— View job


I'll analyze this and get back to you.

@keito4 keito4 self-assigned this Jun 22, 2026
@keito4

keito4 commented Jun 28, 2026

Copy link
Copy Markdown
Owner Author

(aside)
@claude PRがbaseにマージする際にコンフリクトが発生しています。最新のbaseからpullし、修正してください。

@claude

claude Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Claude finished @keito4's task in 9m 10s —— View job


マージコンフリクトの解消 ✅

  • 現在のブランチ状態を確認
  • 最新の main をフェッチ
  • コンフリクトを分析・解消
  • テスト・フォーマット確認
  • 変更をコミット・プッシュ

解消内容

origin/main (PR #893: Karabiner → Kanary 置換) との差分を解消しました。

ファイル 対応
nix/home/karabiner.nix 削除(Kanary置換により不要)
nix/home/default.nix karabiner.nix インポートを削除
nix/hosts/darwin/default.nix kanary.nix インポートを追加
nix/modules/homebrew.nix karabiner-elements を削除
nix/modules/kanary.nix 新規追加(Kanary要件チェック)
docs/adr/0016-use-kanary-for-keyboard-remapping.md 新規追加(ADR)
script/macos/agent-select-input-source.sh 復元(mainに存在)
script/macos/select-input-source.swift 復元(mainに存在)
test/nix-darwin-config.test.js Kanary対応バージョンに更新(9テスト全通過)

コミット: 628a15f
| Branch

最新のmainブランチ(PR #893 でKarabiner→Kanary置換済み)の変更を取り込み
マージコンフリクトを解消する。

- nix/home/karabiner.nix を削除(Kanaryに置換済み)
- nix/home/default.nix からkarabiner.nixのインポートを削除
- nix/hosts/darwin/default.nix にkanary.nixのインポートを追加
- nix/modules/homebrew.nix からkarabiner-elementsを削除
- nix/modules/kanary.nix を追加(Kanary要件チェック)
- docs/adr/0016-use-kanary-for-keyboard-remapping.md を追加
- script/macos/agent-select-input-source.sh を復元
- script/macos/select-input-source.swift を復元
- test/nix-darwin-config.test.js をKanary対応バージョンに更新

Co-authored-by: keito4 <keito4@users.noreply.github.com>
@keito4

keito4 commented Jun 28, 2026

Copy link
Copy Markdown
Owner Author

Closing this PR because it has been superseded by #893, which replaced the Karabiner-based keyboard remapping path with Kanary. The remaining diff is not a separate change to merge.

@keito4 keito4 closed this Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant