fix: wire workflow template validation - #839
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 524f56f387
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| actionlint_flags: >- | ||
| .github/workflows/*.yml | ||
| .github/workflows/templates/*.yml | ||
| templates/workflows/*.yml |
There was a problem hiding this comment.
.yaml workflows in actionlint flags
The path filters at the top of this workflow still trigger CI for **.yaml and .github/workflows/**, but this new explicit file list only passes *.yml globs to actionlint (the pinned reviewdog entrypoint runs actionlint -oneline ${INPUT_ACTIONLINT_FLAGS}). When someone adds or changes a valid GitHub Actions .yaml workflow/template, the Workflow Lint job runs but never checks that file, so syntax or expression errors in the changed workflow can merge. Include the .yaml globs or generate the file list from both extensions.
Useful? React with 👍 / 👎.
|
Addressed in 5284d48: actionlint now uses .yml for .github/workflows, .github/workflows/templates, and templates/workflows so both .yml and .yaml files are covered. Local actionlint and CI Workflow Lint passed after the change. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThree independent workflow changes: Claude workflows (live and template) replace inline draft-PR job-condition filtering with explicit step-based detection using ChangesClaude Workflow Draft PR Detection
CI Workflow Paths-Filter and Actionlint Expansion
Terraform Drift Step-Based Environment Selection
Sequence Diagram(s)sequenceDiagram
participant Webhook as issue_comment event
participant Job as claude job (if: `@claude` mentioned)
participant Script as Check PR draft state
participant GH as github.rest.pulls.get
participant Skip as Skip draft PR
participant Checkout as Checkout repository
participant Runner as Run Claude Code
Webhook->>Job: trigger on `@claude` mention
Job->>Script: execute github-script
Script->>GH: pulls.get(pull_number)
GH-->>Script: isDraft boolean
Script-->>Job: outputs.is_draft = 'true'/'false'
alt is_draft == 'true'
Job->>Skip: log and exit
else is_draft != 'true'
Job->>Checkout: run checkout
Checkout->>Runner: run Claude Code action
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
test/claude-workflow-contract.test.jsOops! Something went wrong! :( ESLint: 10.5.0 ReferenceError: describe is not defined Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
🎉 This PR is included in version 1.117.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 participant
Summary
Verification
Notes
PR #838 was merged before these follow-up fixes could be included. This PR contains only the additional fixes found during review.
Summary by CodeRabbit
Bug Fixes
Chores
Tests